Buy commercial curl support from WolfSSL. We help you work
out your issues, debug your libcurl applications, use the API, port to new
platforms, add new features and more. With a team lead by the curl founder
himself.
Re: Which PRs should we merge?
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Daniel Gustafsson via curl-library <curl-library_at_lists.haxx.se>
Date: Wed, 25 May 2022 11:01:07 +0200
> On 25 May 2022, at 10:01, Daniel Stenberg via curl-library <curl-library_at_lists.haxx.se> wrote:
> On Wed, 25 May 2022, Ray Satiro via curl-library wrote:
>> I don't think a formal 5 user vote system is a good way to get more
>> feedback on a PR but I do think we can make it better with more exposure
>> that a PR needs user feedback.
>
> Okay, so maybe still use the "needs-votes" label but without the thumbs-up concept and instead insist that people speak up in support of it?
I don't think we need to worry about, or formalize, the mechanics of this. The
gist of it is that we need feedback in some form and we should encourage users
to provide that (and also provide visibility for these PRs) - the thumbs-up
reaction might be a lower bar to entry for those users who aren't comfortable
commenting on a high-profile Github project.
I do think having a threshold defined, even if arbitrary at first, can be
helpful for maintainers. Maybe we need to run with this for a while to see if
that's 5, 3, 25 or something else first though?
Date: Wed, 25 May 2022 11:01:07 +0200
> On 25 May 2022, at 10:01, Daniel Stenberg via curl-library <curl-library_at_lists.haxx.se> wrote:
> On Wed, 25 May 2022, Ray Satiro via curl-library wrote:
>> I don't think a formal 5 user vote system is a good way to get more
>> feedback on a PR but I do think we can make it better with more exposure
>> that a PR needs user feedback.
>
> Okay, so maybe still use the "needs-votes" label but without the thumbs-up concept and instead insist that people speak up in support of it?
I don't think we need to worry about, or formalize, the mechanics of this. The
gist of it is that we need feedback in some form and we should encourage users
to provide that (and also provide visibility for these PRs) - the thumbs-up
reaction might be a lower bar to entry for those users who aren't comfortable
commenting on a high-profile Github project.
I do think having a threshold defined, even if arbitrary at first, can be
helpful for maintainers. Maybe we need to run with this for a while to see if
that's 5, 3, 25 or something else first though?
-- Daniel Gustafsson https://vmware.com/ -- Unsubscribe: https://lists.haxx.se/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.htmlReceived on 2022-05-25