Buy commercial curl support from WolfSSL. We help you work
out your issues, debug your libcurl applications, use the API, port to new
platforms, add new features and more. With a team lead by the curl founder
himself.
Re: Which PRs should we merge?
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Daniel Gustafsson via curl-library <curl-library_at_lists.haxx.se>
Date: Tue, 24 May 2022 23:09:21 +0200
> On 24 May 2022, at 17:08, Daniel Stenberg via curl-library <curl-library_at_lists.haxx.se> wrote:
> Here's a thought: what if we create a new label, say "needs-votes" (exact name
> to be decided) that we can set on PRs that we feel have not yet been clearly
> indicated as "desired by the community".
The CONTRIBUTING document should probably then include a small blurb on that,
and also that the 5 votes is (valuable) feedback to the core team and not a
guarantee of merging.
> Such PRs will need, let's say 5 (to start off conservatively), thumbs-up votes
> on GitHub before they can be merged. That way we presumably know that at least
> 5 "separate" users want the feature in curl.
Something along the lines of this is probably where we should start, as it
requires minimal investment in infrastructure and process.
The main issue *I think* is exposure, how do we get those thumbs-up votes cast?
If enough users looked at the open PR's and gave input we wouldn't have this
discussion in the first place. Now, it might well be that a thumbs-up vote is
less intimidating than commenting/reviewing and has a lower contribution
barrier, and I think there is some truth to that. The only way to know is to
test it.
> We could of course also allow thumbs-down for "I really don't think this should
> be merged".
I think we should stick to thumbs-up's.
Date: Tue, 24 May 2022 23:09:21 +0200
> On 24 May 2022, at 17:08, Daniel Stenberg via curl-library <curl-library_at_lists.haxx.se> wrote:
> Here's a thought: what if we create a new label, say "needs-votes" (exact name
> to be decided) that we can set on PRs that we feel have not yet been clearly
> indicated as "desired by the community".
The CONTRIBUTING document should probably then include a small blurb on that,
and also that the 5 votes is (valuable) feedback to the core team and not a
guarantee of merging.
> Such PRs will need, let's say 5 (to start off conservatively), thumbs-up votes
> on GitHub before they can be merged. That way we presumably know that at least
> 5 "separate" users want the feature in curl.
Something along the lines of this is probably where we should start, as it
requires minimal investment in infrastructure and process.
The main issue *I think* is exposure, how do we get those thumbs-up votes cast?
If enough users looked at the open PR's and gave input we wouldn't have this
discussion in the first place. Now, it might well be that a thumbs-up vote is
less intimidating than commenting/reviewing and has a lower contribution
barrier, and I think there is some truth to that. The only way to know is to
test it.
> We could of course also allow thumbs-down for "I really don't think this should
> be merged".
I think we should stick to thumbs-up's.
-- Daniel Gustafsson https://vmware.com/ -- Unsubscribe: https://lists.haxx.se/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.htmlReceived on 2022-05-24