Buy commercial curl support from WolfSSL. We help you work
out your issues, debug your libcurl applications, use the API, port to new
platforms, add new features and more. With a team lead by the curl founder
himself.
[PATCH] Revert "ftp: Expression 'ftpc->wait_data_conn' is always false"
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Jonathan Wernberg via curl-library <curl-library_at_cool.haxx.se>
Date: Wed, 7 Jul 2021 13:09:39 +0000
Hi. I could not make a GitHub pull request at this point in time, I hope it is acceptable to send the patch this way instead. The patch is attached. This reverts commit 49f3117a238b6eac0e22a32f50699a9eddcb66ab from 2019, that introduced a subtle logic error in FTP file upload handling in active transfer mode. Longer description of the error is in the commit message. There are some other similar commits made at the same time, related to https://github.com/curl/curl/issues/4374, that may be wrong as well. I have not looked into that. You may want to review them a second time.
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.se/mail/etiquette.html
Received on 2021-07-07
Date: Wed, 7 Jul 2021 13:09:39 +0000
Hi. I could not make a GitHub pull request at this point in time, I hope it is acceptable to send the patch this way instead. The patch is attached. This reverts commit 49f3117a238b6eac0e22a32f50699a9eddcb66ab from 2019, that introduced a subtle logic error in FTP file upload handling in active transfer mode. Longer description of the error is in the commit message. There are some other similar commits made at the same time, related to https://github.com/curl/curl/issues/4374, that may be wrong as well. I have not looked into that. You may want to review them a second time.
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.se/mail/etiquette.html
- text/x-patch attachment: 0001-Revert-ftp-Expression-ftpc-wait_data_conn-is-always-.patch