Buy commercial curl support from WolfSSL. We help you work
out your issues, debug your libcurl applications, use the API, port to new
platforms, add new features and more. With a team lead by the curl founder
himself.
Re: Problems with empty header values in header API in 8.5.0/master
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Dmitry Karpov via curl-library <curl-library_at_lists.haxx.se>
Date: Wed, 10 Jan 2024 19:24:51 +0000
It used to work somehow. 😊
But I am glad that you fixed it.
-----Original Message-----
From: Daniel Stenberg <daniel_at_haxx.se>
Sent: Wednesday, January 10, 2024 12:27 AM
To: Dmitry Karpov via curl-library <curl-library_at_lists.haxx.se>
Cc: Dmitry Karpov <dkarpov_at_roku.com>
Subject: [EXTERNAL] Re: Problems with empty header values in header API in 8.5.0/master
On Tue, 9 Jan 2024, Dmitry Karpov via curl-library wrote:
> I noticed a strange regression related to header API when migrated
> from 7.84 to 8.5.0, and I see the same issue in TOT branch. The issue
> is that the header API returns '\r' as a header value when some
> service returns a header with no value (like: hdr: \r\n).
>
> The 7.84 returns expected empty string in such cases. Is a bug or some
> behavior change?
I could not spot when this broke. To me it looks like the logic was always wrong (and the test case did not verify blank header content):
https://github.com/curl/curl/pull/12675
--
/ daniel.haxx.se
| Commercial curl support up to 24x7 is available!
| Private help, bug fixes, support, ports, new features
| https://curl.se/support.html
Date: Wed, 10 Jan 2024 19:24:51 +0000
It used to work somehow. 😊
But I am glad that you fixed it.
-----Original Message-----
From: Daniel Stenberg <daniel_at_haxx.se>
Sent: Wednesday, January 10, 2024 12:27 AM
To: Dmitry Karpov via curl-library <curl-library_at_lists.haxx.se>
Cc: Dmitry Karpov <dkarpov_at_roku.com>
Subject: [EXTERNAL] Re: Problems with empty header values in header API in 8.5.0/master
On Tue, 9 Jan 2024, Dmitry Karpov via curl-library wrote:
> I noticed a strange regression related to header API when migrated
> from 7.84 to 8.5.0, and I see the same issue in TOT branch. The issue
> is that the header API returns '\r' as a header value when some
> service returns a header with no value (like: hdr: \r\n).
>
> The 7.84 returns expected empty string in such cases. Is a bug or some
> behavior change?
I could not spot when this broke. To me it looks like the logic was always wrong (and the test case did not verify blank header content):
https://github.com/curl/curl/pull/12675
--
/ daniel.haxx.se
| Commercial curl support up to 24x7 is available!
| Private help, bug fixes, support, ports, new features
| https://curl.se/support.html
-- Unsubscribe: https://lists.haxx.se/mailman/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.htmlReceived on 2024-01-10