RE: [RELEASE] curl 7.86.0

From: Randall via curl-library <curl-library_at_lists.haxx.se>
Date: Wed, 26 Oct 2022 10:26:40 -0400

>-----Original Message-----
>From: Daniel Stenberg <daniel_at_haxx.se>
On October 26, 2022 10:12 AM, Daniel Stenberg wrote:
>On Wed, 26 Oct 2022, rsbecker_at_nexbridge.com wrote:
>
>> Snippet to do that:
>>
>> #if defined __TANDEM
>> typedef long long curl_off_t;
>> #endif
>>
>> Best place to do that? In configure or just curl.h?
>
>In should be in curl/system.h. Make like this?
>
>diff --git a/include/curl/system.h b/include/curl/system.h index
>8d56b8a4a..8cdf25fa4 100644
>--- a/include/curl/system.h
>+++ b/include/curl/system.h
>_at__at_ -170,10 +170,18 _at__at_
> # define CURL_FORMAT_CURL_OFF_TU "llu"
> # define CURL_SUFFIX_CURL_OFF_T LL
> # define CURL_SUFFIX_CURL_OFF_TU ULL
> # define CURL_TYPEOF_CURL_SOCKLEN_T int
>
>+#elif defined(__TANDEM)
>+# define CURL_TYPEOF_CURL_OFF_T long long
>+# define CURL_FORMAT_CURL_OFF_T "lld"
>+# define CURL_FORMAT_CURL_OFF_TU "llu"
>+# define CURL_SUFFIX_CURL_OFF_T LL
>+# define CURL_SUFFIX_CURL_OFF_TU ULL
>+# define CURL_TYPEOF_CURL_SOCKLEN_T int
>+
> #elif defined(_WIN32_WCE)
> # define CURL_TYPEOF_CURL_OFF_T __int64
> # define CURL_FORMAT_CURL_OFF_T "I64d"
> # define CURL_FORMAT_CURL_OFF_TU "I64u"
> # define CURL_SUFFIX_CURL_OFF_T i64

Close... we should include

&& !defined(__LP64)

to the #elif. If we build under 64-bit, which is scheduled later in the
year, then there is no need to override the defaults. Do you want a PR for
this?

-- 
Unsubscribe: https://lists.haxx.se/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html

Received on 2022-10-26