Buy commercial curl support from WolfSSL. We help you work
out your issues, debug your libcurl applications, use the API, port to new
platforms, add new features and more. With a team lead by the curl founder
himself.
RE: Does support for FTP growing files work in libcurl?
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Robert Sumner via curl-library <curl-library_at_lists.haxx.se>
Date: Tue, 18 Oct 2022 13:57:58 +0100
-----Original Message-----
From: Daniel Stenberg <daniel_at_haxx.se>
Sent: 18 October 2022 08:43
To: fractal.sumner_at_btinternet.com
Cc: 'Robert Sumner via curl-library' <curl-library_at_lists.haxx.se>
Subject: RE: Does support for FTP growing files work in libcurl?
On Mon, 17 Oct 2022, fractal.sumner_at_btinternet.com wrote:
> Thanks very much for your response, and I take your point about the
> FTP protocol in this respect. However, isn't the reason for having the
> optional setting CURLOPT_IGNORE_CONTENT_LENGTH to give the caller a
> way to absolve libcurl of providing this check and saying to it please
> just give me everything the server gives you on the data socket. The
> onus then being on the caller to check that they got what they wanted?
>
> As the man page for CURLOPT_IGNORE_CONTENT_LENGTH says, this then
> allows growing files to be supported, which is a nice feature, albeit
> one that isn't as robust as for standard fixed transfers. The code to
> support this option appears in the code base, but it looks to just
> have one small issue that prevents it working. I took a clone of the
> latest version and put the small fix in, which then allowed growing files
to work for me locally.
Seems like a worthfile fix indeed.
Would you be able to make a pull-request out of your proposal? I would also
like to see a test added for this...
Date: Tue, 18 Oct 2022 13:57:58 +0100
-----Original Message-----
From: Daniel Stenberg <daniel_at_haxx.se>
Sent: 18 October 2022 08:43
To: fractal.sumner_at_btinternet.com
Cc: 'Robert Sumner via curl-library' <curl-library_at_lists.haxx.se>
Subject: RE: Does support for FTP growing files work in libcurl?
On Mon, 17 Oct 2022, fractal.sumner_at_btinternet.com wrote:
> Thanks very much for your response, and I take your point about the
> FTP protocol in this respect. However, isn't the reason for having the
> optional setting CURLOPT_IGNORE_CONTENT_LENGTH to give the caller a
> way to absolve libcurl of providing this check and saying to it please
> just give me everything the server gives you on the data socket. The
> onus then being on the caller to check that they got what they wanted?
>
> As the man page for CURLOPT_IGNORE_CONTENT_LENGTH says, this then
> allows growing files to be supported, which is a nice feature, albeit
> one that isn't as robust as for standard fixed transfers. The code to
> support this option appears in the code base, but it looks to just
> have one small issue that prevents it working. I took a clone of the
> latest version and put the small fix in, which then allowed growing files
to work for me locally.
Seems like a worthfile fix indeed.
Would you be able to make a pull-request out of your proposal? I would also
like to see a test added for this...
-- Yes, I'll put a PR. I'll add some notes about how I've been testing but might need some pointers/help to create a proper test. Thanks Rob -- Unsubscribe: https://lists.haxx.se/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.htmlReceived on 2022-10-18