curl / Mailing Lists / curl-library / Single Mail
Buy commercial curl support from WolfSSL. We help you work out your issues, debug your libcurl applications, use the API, port to new platforms, add new features and more. With a team lead by the curl founder himself.

Re: Fewer mallocs is better, episode #47

From: Cristian Rodríguez via curl-library <curl-library_at_lists.haxx.se>
Date: Tue, 1 Feb 2022 09:17:43 -0300

On Tue, Feb 1, 2022 at 8:33 AM Henrik Holst via curl-library
<curl-library_at_lists.haxx.se> wrote:
>
> did find one low hanging fruit and one interesting strcpy reimplementation:

> --- a/lib/urlapi.c
> +++ b/lib/urlapi.c
> _at__at_ -1005,9 +1005,7 _at__at_ static CURLUcode seturl(const char *url, CURLU *u, unsigned int flags)
> return CURLUE_NO_HOST;
> }
>
> - len = strlen(p);
> - memcpy(path, p, len);
> - path[len] = 0;
> + strcpy(path, p);
>

Did the generated code change on this bit though ? I believe gcc
recognizes both variations (the original and strcpy) and will change
it to stpcpy or memcpy..
-- 
Unsubscribe: https://lists.haxx.se/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html
Received on 2022-02-01