curl / Mailing Lists / curl-library / Single Mail

Buy commercial curl support from WolfSSL. We help you work out your issues, debug your libcurl applications, use the API, port to new platforms, add new features and more. With a team lead by the curl founder himself.

Re: make test: SHUT_RDWR, SHUT_RD, SHUT_WR not defined

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]

From: Kevin R. Bulgrien via curl-library <curl-library_at_cool.haxx.se>
Date: Tue, 20 Apr 2021 02:33:16 -0500 (CDT)

> > -#ifdef USE_WINSOCK
> > +#if defined(USE_WINSOCK) || \
> > + !defined(SHUT_RD) && (defined(HAVE_SOCKET_H) ||
> > defined(HAVE_SYS_SOCKET_H))
> > # define SHUT_RD 0x00
> > # define SHUT_WR 0x01
> > # define SHUT_RDWR 0x02
>
> Isn't it better to just do #ifndef for each define? Like this:
>
> https://github.com/curl/curl/pull/6925

Thanks for the change. The intent was to suggest an edit in
a manner that clearly communicated what was wrong. It is
perfectly fine for the patch to look different than what
was proposed as it accomplishes the end goal.

Kevin R. Bulgrien
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.se/mail/etiquette.html
Received on 2021-04-20

This message: [ Message body ]
Next message: Daniel Stenberg via curl-library: "Re: libtls support"
Previous message: Daniel Stenberg via curl-library: "Re: make test: SHUT_RDWR, SHUT_RD, SHUT_WR not defined"
In reply to: Daniel Stenberg via curl-library: "Re: make test: SHUT_RDWR, SHUT_RD, SHUT_WR not defined"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]