Buy commercial curl support. We
help you work out your issues, debug your libcurl applications, use the API,
port to new platforms, add new features and more. With a team lead by the
curl founder Daniel himself.
Re: curl exit code change after 335dc0e3c5968827 intentional?
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Fabian Keil via curl-library <curl-library_at_lists.haxx.se>
Date: Wed, 13 May 2026 14:53:24 +0200
Fabian Keil via curl-library <curl-library_at_lists.haxx.se> wrote on 2026-04-15 at 15:31:35:
> Daniel Stenberg <daniel_at_haxx.se> wrote on 2026-04-13 at 19:28:26:
>
> > On Mon, 13 Apr 2026, Fabian Keil via curl-library wrote:
> >
> > > test 0004...[Request from client address from denied network range]
> > >
> > > curl returned 56, when expecting 52
> >
> > Clearly your test case now fails differently, so it gets another error code
> > because 52 is still there and returned for the same reason. We even have test
> > cases for it.
> >
> > It would be helpful if you could make a test case with the curl test suite
> > that reproduces the problem you experience.
>
> The patch set at [0] adds a test server that drops connections
> without returning data and adds two tests that use it.
>
> curl versions before 335dc0e3c report an "Empty reply from server",
> afterwards its a "Failure in receiving network data".
[...]
> [0] <https://www.fabiankeil.de/sourcecode/curl-connection-dropper-tests.diff>
Should I submit a PR to get a review or is the patch considered not worth it?
Fabian
Date: Wed, 13 May 2026 14:53:24 +0200
Fabian Keil via curl-library <curl-library_at_lists.haxx.se> wrote on 2026-04-15 at 15:31:35:
> Daniel Stenberg <daniel_at_haxx.se> wrote on 2026-04-13 at 19:28:26:
>
> > On Mon, 13 Apr 2026, Fabian Keil via curl-library wrote:
> >
> > > test 0004...[Request from client address from denied network range]
> > >
> > > curl returned 56, when expecting 52
> >
> > Clearly your test case now fails differently, so it gets another error code
> > because 52 is still there and returned for the same reason. We even have test
> > cases for it.
> >
> > It would be helpful if you could make a test case with the curl test suite
> > that reproduces the problem you experience.
>
> The patch set at [0] adds a test server that drops connections
> without returning data and adds two tests that use it.
>
> curl versions before 335dc0e3c report an "Empty reply from server",
> afterwards its a "Failure in receiving network data".
[...]
> [0] <https://www.fabiankeil.de/sourcecode/curl-connection-dropper-tests.diff>
Should I submit a PR to get a review or is the patch considered not worth it?
Fabian
-- Unsubscribe: https://lists.haxx.se/mailman/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.htmlReceived on 2026-05-13