curl / Mailing Lists / curl-library / Single Mail
Buy commercial curl support from WolfSSL. We help you work out your issues, debug your libcurl applications, use the API, port to new platforms, add new features and more. With a team lead by the curl founder himself.

Re: Test 1061 flaky when run without valgrind

From: Ray Satiro via curl-library <>
Date: Mon, 11 Jan 2021 03:30:56 -0500

On 1/11/2021 3:01 AM, Fabian Keil via curl-library wrote:
> Ray Satiro via curl-library<> wrote on 2021-01-10:
>> On 1/10/2021 5:33 PM, Daniel Stenberg via curl-library wrote:
>>> On Sun, 10 Jan 2021, Fabian Keil via curl-library wrote:
>>>> The attached patch seems to work around the problem.
>>>> Busy-looping probably isn't the right solution, though.
>>> Yeah, that's just not the right fix.
>>> When the code returns there (http_proxy.c line 346) due to CURLE_AGAIN
>>> having been returned from the read function, it should return back out
>>> to the multi state-machine where it should remain in the
>>> CURLM_STATE_WAITPROXYCONNECT state until the socket gets readable
>>> again and it calls Curl_http_connect() again to continue to the
>>> CONNECT handling.
>>> Can you rebuild with --enable-debug and see if the extra output shines
>>> some more light on this? Presumably, in your case the code moves on to
>>> the next state somehow when it shouldn't and we should figure out why!
>> +1 we want it non-blocking. I can't reproduce this but I took a guess.
>> Can you please try
> Good guess. The commit 1253e5f4ba1210 makes the test
> succeed 1000 times in a row.

Thanks, I just landed it in master. [1]


Received on 2021-01-11