Buy commercial curl support from WolfSSL. We help you work
out your issues, debug your libcurl applications, use the API, port to new
platforms, add new features and more. With a team lead by the curl founder
himself.
Re: Potential confusion in http_proxy.c and a recommendation
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Hasabnis, Niranjan via curl-library <curl-library_at_cool.haxx.se>
Date: Mon, 9 Nov 2020 23:08:34 +0000
Thanks for confirming. The proposal in PR 6193 looks good to me.
Thanks,
Niranjan.
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Monday, November 9, 2020 at 2:51 PM
To: Hasabnis, Niranjan via curl-library <curl-library_at_cool.haxx.se>
Cc: Hasabnis, Niranjan <niranjan.hasabnis_at_intel.com>, Gottschlich, Justin <justin.gottschlich_at_intel.com>
Subject: Re: Potential confusion in http_proxy.c and a recommendation
On Mon, 9 Nov 2020, Hasabnis, Niranjan via curl-library wrote:
> We believe that using “if (s->keepon > 1)” would eliminate this confusion
> and capture the intended semantics precisely.
I think you've pointed out code that could be written clearer, yes. But I
think an even better improvement to this logic would be to use an enum or
defined values that include all three used values as state names.
What do you think about my proposal over at:
https://github.com/curl/curl/pull/6193
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2020-11-10
Date: Mon, 9 Nov 2020 23:08:34 +0000
Thanks for confirming. The proposal in PR 6193 looks good to me.
Thanks,
Niranjan.
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Monday, November 9, 2020 at 2:51 PM
To: Hasabnis, Niranjan via curl-library <curl-library_at_cool.haxx.se>
Cc: Hasabnis, Niranjan <niranjan.hasabnis_at_intel.com>, Gottschlich, Justin <justin.gottschlich_at_intel.com>
Subject: Re: Potential confusion in http_proxy.c and a recommendation
On Mon, 9 Nov 2020, Hasabnis, Niranjan via curl-library wrote:
> We believe that using “if (s->keepon > 1)” would eliminate this confusion
> and capture the intended semantics precisely.
I think you've pointed out code that could be written clearer, yes. But I
think an even better improvement to this logic would be to use an enum or
defined values that include all three used values as state names.
What do you think about my proposal over at:
https://github.com/curl/curl/pull/6193
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2020-11-10