On Wed, 6 Sep 2017, Patrick Monnerat via curl-library wrote:

> non-ascii.c:122:21: warning: passing argument 2 of ‘iconv’ from incompatible
> pointer type [-Wincompatible-pointer-types]
> rc = iconv(*cd, (const char **)&input_ptr, &in_bytes,

...

> Maybe we should determine iconv() argument types at configure time to avoid
> these warnings, then check as shown above in Travis CI.

Yes, that sounds excellent! We could *possibly* get away with just #ifdefs for
it, since then it'll be much easier to get it to work with other build systems
too. But I don't know what systems that have this as "const char *"...

Googling about this issue, I found that others have ran into this problem
before [1], as the standard [2] says it should be const, but the glibc
maintainer with a "strong personality" dismissed that pretty hard [3] back in
the day.

Maybe we should just start out with removing the 'const' there and then wait
for people to report when *that* causes warnings and then we can add #ifdefs
for it then... ?

[1] = https://github.com/win-iconv/win-iconv/issues/8
[2] = http://pubs.opengroup.org/onlinepubs/007908799/xsh/iconv.html
[3] = https://sourceware.org/bugzilla/show_bug.cgi?id=2962

-- 
  / daniel.haxx.se

-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2017-09-07