On 9/6/2017 11:27 PM, Daniel Stenberg wrote:
> Googling about this issue, I found that others have ran into this
> problem before [1], as the standard [2] says it should be const, but
> the glibc maintainer with a "strong personality" dismissed that pretty
> hard [3] back in the day.
>
> Maybe we should just start out with removing the 'const' there and
> then wait for people to report when *that* causes warnings and then we
> can add #ifdefs for it then... ?
>
> [1] = https://github.com/win-iconv/win-iconv/issues/8
> [2] = http://pubs.opengroup.org/onlinepubs/007908799/xsh/iconv.html
> [3] = https://sourceware.org/bugzilla/show_bug.cgi?id=2962

The response in [3] is kind of snippy because [2] is out of date.
Standard iconv() [4] now uses "char ** restrict" for the second
argument.  Since I am out of my comfort zone here, I won't try to figure
out when the change was made official, but it appears to have been 2004
[5] or earlier.  I can't help with patching either; I am a mere mortal
in libcurl world.

So yeah, I'd remove the "const" and wait for complaints.  Hopefully they
will be more polite than the developer in [3]...

[4] = http://pubs.opengroup.org/onlinepubs/9699919799/functions/iconv.html
[5] = http://pubs.opengroup.org/onlinepubs/009695399/functions/iconv.html

-- 
     David Chapman      dcchapman_at_acm.org
     Chapman Consulting -- San Jose, CA
     Software Development Done Right.
     www.chapman-consulting-sj.com
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html