cURL / Mailing Lists / curl-library / Single Mail


RE: [PATCH] smtps with openssl

From: Nagel, Bill <>
Date: Fri, 26 Sep 2014 18:55:01 +0000

Updated patch is attached.

-----Original Message-----
From: curl-library [] On Behalf Of Steve Holme
Sent: Thursday, September 25, 2014 12:27 PM
To: libcurl development
Subject: RE: [PATCH] smtps with openssl

On Wed, 17 Sep 2014, Nagel, Bill wrote:

> This patch fixes the "SSL3_WRITE_PENDING: bad write retry" error that

> sometimes occurs when sending an email over smtps with openssl.

> openssl appears to require the same pointer on a write that follows a

> retry (CURLE_AGAIN).

Just a couple of niggles whilst I mull the patch over:

* You don't test for OOM on the strdup() operation. Admitidly the original code didn't but we should return CURLE_OUT_OF_MEMORY if it does fail.

* I think you have introduced a memory leak if Curl_write() fails.

Kind Regards

List admin:


This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments.

List admin:

Received on 2014-09-26