cURL / Mailing Lists / curl-library / Single Mail


RE: [PATCH] smtps with openssl

From: Steve Holme <>
Date: Thu, 25 Sep 2014 17:27:14 +0100

On Wed, 17 Sep 2014, Nagel, Bill wrote:

> This patch fixes the "SSL3_WRITE_PENDING: bad write retry" error that

> sometimes occurs when sending an email over smtps with openssl.

> openssl appears to require the same pointer on a write that follows a

> retry (CURLE_AGAIN).

Just a couple of niggles whilst I mull the patch over:

* You don't test for OOM on the strdup() operation. Admitidly the original code didn't but we should return CURLE_OUT_OF_MEMORY if it does fail.

* I think you have introduced a memory leak if Curl_write() fails.

Kind Regards

List admin:
Received on 2014-09-25