cURL / Mailing Lists / curl-library / Single Mail


RE: [PATCH] smtps with openssl

From: Steve Holme <>
Date: Fri, 26 Sep 2014 22:47:29 +0100

On Fri 26 Sep 2014, Nagel, Bill wrote:

> Updated patch is attached.

Thank you - but please don't top post.

A couple of more niggles... which I can fix up when I push but for your future reference:

* The new if statement doesn't adhere to or coding standards
* I try and avoid using assignment operators inside a comparison where possible - it makes things clearer imho and negates the extra brackets that are then required

Additionally, is this behaviour of OpenSSL documented anywhere as:

a) This would be useful for inclusion in the git commit comment
b) I've personally not seen this error (even though I use OpenSSL I tend to use straight SMTP and occasionally explicit SMTPS)
c) We can't really test this with our test harness (that I know of)

Kind Regards


List admin:
Received on 2014-09-26