curl-library
RE: [PATCH] smtps with openssl
Date: Fri, 26 Sep 2014 22:20:58 +0000
> -----Original Message-----
> From: curl-library [mailto:curl-library-bounces_at_cool.haxx.se] On Behalf Of
> Steve Holme
> Sent: Friday, September 26, 2014 5:47 PM
> To: 'libcurl development'
> Subject: RE: [PATCH] smtps with openssl
>
> On Fri 26 Sep 2014, Nagel, Bill wrote:
>
> > Updated patch is attached.
>
> Thank you - but please don't top post.
>
> A couple of more niggles... which I can fix up when I push but for your future
> reference:
>
> * The new if statement doesn't adhere to or coding standards
> * I try and avoid using assignment operators inside a comparison where
> possible - it makes things clearer imho and negates the extra brackets that
> are then required
>
> Additionally, is this behaviour of OpenSSL documented anywhere as:
>
> a) This would be useful for inclusion in the git commit comment
> b) I've personally not seen this error (even though I use OpenSSL I tend to
> use straight SMTP and occasionally explicit SMTPS)
> c) We can't really test this with our test harness (that I know of)
>
> Kind Regards
>
> Steve
>
> -------------------------------------------------------------------
There is a thread about it here:
One comment mentions that even the address of the pointer has to be the same. I was only able to hit this failure with the native Windows build of curl while sending attachments with smtps, but that is my primary usage cause, so I see this failure frequently.
thanks,
Bill
________________________________
This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-09-27