Re: [PATCH 1/7] Comment and debug output fixes.
Date: Sun, 9 Nov 2014 22:04:40 +0100
On Sun, 9 Nov 2014 19:35:11 +0000
Steve Holme <steve_holme_at_hotmail.com> wrote:
> Now we have identified a problem of only enclosing attachments and
> not performing inline patches :-P
I can now... opening it an xterm with 'less'.
I supposes the problem is that the mime you use
is for binary (application/octet-stream) so that
it's not trivial for my mailer to know that I want
to see it as a text file.
But I assume you need that in order to preserve the
line endings - it's a sad world.
When I attach a .diff file, I'm pretty sure my mailer
will happily put it inline as text.. so we'll see if
that is going to work for you :p
> > Can you please tell me what I did wrong? I used gits email function
> > and it produced the emails as they are. What did you have to change?
> I appreciate I'm on Windows so do things a little differently, but I
> tend to generate the patch as a normal file and attach it rather than
> use Git's email functionality. I'm not too sure why it didn't come
> through though - have attached it again.
> > > http://curl.haxx.se/dev/contribute.html
> > I think I followed the instructions from there.
> You weren't far off and it was quiet difficult to tell what line
> reformatting Outlook / Hotmail did:
> * The area was missing from the first line. I changed it from
> "Comment and debug output fixes.", to "cleanup: Comment and debug
> fixes", although "connections: Clean-up of comments and debug fixes"
> amongst others would have been good I guess.
Ah ok - I added that in the other patches (all being 'pipelining:').
It's hard to add that when you already have so few characters for the
> * A personal hatred - I avoid full stops at the end of the first line
> as it is description or subject rather than a sentence (very picky of
> me I know!)
Is it just personal or should I remove them? Personally I'm very keen
on adding punctuation EVERYWHERE (code comments, debug output(!) and
git commit messages :p.
> * I reformatted the full description to use spacing between the
> different fixes and tried to make better use of the 72 character limit
I thought I already had limited them to 72... Or maybe it was 80: my
editor, when typing in a commit message, is aware that it is a git
comment and makes characters red that are too wide and/or auto wraps. I
assumed that the limits that it uses are standard.
> As I said, the latter may be Outlook / Hotmail's fault.
> > I was copying what Peter Wu did/does...
> There is no hard and fast rule on this:
> 1) Some people quote the patches in emails / use git's email
> functionality (Like you have Peter have) 2) Some (like me when I used
> to submit my patches to the mailing list - or when I need others
> assistance / input on a patch) will add them as attachments 3)
> Others, do both
> The problem with 1) is that the line endings from the email can cause
> problems for msysgit / TortoiseGit so anyone on Windows has to copy
> the text and then save it using UNIX line endings where as an
> attachment they are preserved (Although it doesn't stop a Windows
> user having git configured incorrectly and sending them through with
> CRLF) and for example, I can simply drag the file from Outlook into
> my curl folder ;-) Not only but the line endings also get lost
> although sometimes as well:
> diff --git a/lib/conncache.c b/lib/conncache.c
> index 9522aeb..f63a8f5 100644
> ...ends up being
> diff --git a/lib/conncache.c b/lib/conncache.c index 9522aeb..f63a8f5
> ...and it normally takes me a while to realise when I receive an
> incorrect character at line x error from TortoiseGit :(
> As such I don't often review the inline patches unless they are quite
> The problem with 2), as we found out, is that some people can't open
> Kind Regards
Imho, using a mailing-list to submit patches reduces the work flow to
that of RCS or the likes. Trying to get a linear history has a lot more
disadvantages than advantages (if any). I love git, with all its power
and flexibility... but ok, this is just a bunch of patches and then I'm
gone again (hopefully; so very busy with other stuff). So, I'll just try
to satisfy you :p. Lemme know if there are still problems the next time
I post a (revised) patch.
-- Carlo Wood <carlo_at_alinoe.com> ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.htmlReceived on 2014-11-09