On Mon, Aug 18, 2014 at 3:00 AM, <curl-library-request_at_cool.haxx.se> wrote:
>
> Date: Sun, 17 Aug 2014 22:52:04 +0200 (CEST)
> From: Daniel Stenberg <daniel_at_haxx.se>
> To: libcurl development <curl-library_at_cool.haxx.se>
> Subject: Re: [PATCH] tool: add --retry-connrefused
> Message-ID: <alpine.DEB.2.00.1408172248310.23727_at_tvnag.unkk.fr>
> Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
>
> On Sat, 16 Aug 2014, Daniel Hwang wrote:
>
> > I have executed http://curl.haxx.se/mail/archive-2010-05/0066.html. The
> > objective was to add an option to consider "connection refused" errors as
> > transient in a retry.
> >
> > I have tested my changes using the following approach:
> > https://gist.github.com/gnawhleinad/6860bedb4de5a3776ecd#file-readme-md
>
> Thanks a lot for helping out to improve our project!
>
> I have a little issue with this patch (apart from it not having any docs
> nor
> test cases accompanying it):
>
>
I'll look into this more. I couldn't find the tool's test cases in the
source.

> - It doesn't really do what it claims. Or rather it does a lot more!
>
> The naming of this option gives the user the impression that this retries
> for
> connection refused problems, while in reality it makes curl retry for _all_
> and _any_ connection failures that occur.
>
> I could be fine with that, if that's what you intend but we really can't
> have
> the option named like this then!
>

This was not my intention, and I have fixed this. Please see the attached
patch 2/2 or https://gist.github.com/gnawhleinad/6860bedb4de5a3776ecd

Thanks,

Daniel Hwang

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html