On Thu, 22 May 2014, Dan Fandrich wrote:

> > > http: Fix a compiler warning when http2 support is disabled
> >
> > I contemplated this fix but I went with commit c6d5f80d instead which
> > defined Curl_http2_setup() as Curl_nop_stmt when http2 is disabled.
> >
> > As such, I'm just wondering if my fix worked and if the second fix is
> > needed?
>
> No, I just didn't notice your change coming in when I rebased mine, since
> there were no conflicts. I did mine the day before but neglected to push
> it right away.

No problem - I went with the header file fix in case someone (in the future)
saw the braces on the else and removed them as I know we tend not to put
braces around one line if or else statements.

Anyway I'd be interested to know if my fix worked if someone would be so
kind to put me out my misery ;-)

Kind Regards

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-05-22