On Thu, May 22, 2014 at 08:21:02PM +0100, Steve Holme wrote:
> On Thu, 22 May 2014, GitHub wrote:
>
> > http: Fix a compiler warning when http2 support is disabled
>
> I contemplated this fix but I went with commit c6d5f80d instead which
> defined Curl_http2_setup() as Curl_nop_stmt when http2 is disabled.
>
> As such, I'm just wondering if my fix worked and if the second fix is
> needed?

No, I just didn't notice your change coming in when I rebased mine, since
there were no conflicts. I did mine the day before but neglected to push it
right away.

> Also, if my fix didn't work should I revert it and more importantly why
> didn't it work?

I didn't test it since I didn't notice it, so I can't say. It's now twice as
likely that the warning was killed!

>>> Dan
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-05-22