On Thu, 7 Mar 2013, Yves Arrouye wrote:

please don't top-post!

> No I didn't post a patch, I sent you a link to the clone I have on Github.

Can you please post your work as a patch (or patch series) here?

> So I just moved the token reading code outside of lib. It depends on
> Curl_urlfmtdecode for reading tokens that are in
> application/x-www-form-urlencoded format (I modified that function as part
> of my patch to support both URL encoding and the form variant).
>
> What would be best in curl?
>
> 1. Keep the simple token parsing function as a courtesy to users in the
> lib (but remove the one that reads from a file)?
> 2. Have my own decoder in the token parsing code since it's now outside of
> the library? (Seems like a lot of duplication).
> 3. Some other option I haven't thought about. Maybe add a
> curl_easy_unescape_form that can be called by anybody, and rely on that?
> You may deem this more generic and therefore more useful than the token
> reading function.

Can you tell us more about what the token is used for and what kind of parsing
that is necessary? Is that token usually stored in a file using a particular
format? I'm not very knowledgable in oauth magic.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html