cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Fix CURLMOPT_MAXCONNECTS

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 4 Feb 2013 23:50:57 +0100 (CET)

On Wed, 23 Jan 2013, Linus Nielsen Feltzing wrote:

> And here is the third version. No more hard coded IP address and port number
> in the test case.

Okay, here's the patch I just created after applying yours and some fiddling.
Gzipped to preserve the line endings etc.

(A little nit: in commit messages, please use a short first line, then an
empty line and them the long description.)

Unfortunately test case 1506 fails for me when I run runtests with -n
(disabling valgrind) but not without, which hints that there's a timing issue
somewhere playing tricks:

  1506: output (log/stderr1506) FAILED:
--- log/check-expected 2013-02-04 23:48:41.274548396 +0100
+++ log/check-generated 2013-02-04 23:48:41.274548396 +0100
@@ -1,5 +1,4 @@
-* Connection #0 to host server1.example.com left intact
+* Closing connection 0
  * Connection #1 to host server2.example.com left intact
  * Connection #2 to host server3.example.com left intact
-* Closing connection 0
  * Connection #3 to host server4.example.com left intact

  - abort tests
TESTDONE: 0 tests out of 1 reported OK: 0%
TESTFAIL: These test cases failed: 1506

-- 
  / daniel.haxx.se


-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2013-02-04