cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Fix CURLMOPT_MAXCONNECTS

From: Linus Nielsen Feltzing <linus_at_haxx.se>
Date: Tue, 05 Feb 2013 09:22:28 +0100

On 02/04/2013 11:50 PM, Daniel Stenberg wrote:
> On Wed, 23 Jan 2013, Linus Nielsen Feltzing wrote:
>
>> And here is the third version. No more hard coded IP address and port
>> number in the test case.
>
> Okay, here's the patch I just created after applying yours and some
> fiddling. Gzipped to preserve the line endings etc.

Thanks!

> (A little nit: in commit messages, please use a short first line, then
> an empty line and them the long description.)

I'll remember that.

> Unfortunately test case 1506 fails for me when I run runtests with -n
> (disabling valgrind) but not without, which hints that there's a timing
> issue somewhere playing tricks:

Yes, there was a race, since all handles ran at the same time. I now run
the requests one by one to eliminate the risk of a race.

New patch is attached.

Linus

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

  • application/x-gzip attachment: stored
Received on 2013-02-05