> Out of curiosity do you know what the knock on effect of this is, by not
> calling smtp_dophase_done() ?

I see from the code that it is already a little ambiguous as to whether
> smtp_dophase_done() or smtp_disconnect() frees up the domain for example.
>
>
I can only confirm there is no memory leak occuring.

> Would it not be better to do:
>
> if(*dophase_done) {
> smtp_dophase_done(conn, FALSE /* not connected */);
>
> DEBUGF(infof(conn->data, "DO phase is complete\n"));
> }
>
>
it looks to a better idea, I copied FTP's way without big considerations.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2012-05-22