cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: VC Makefile changes/improvements

From: Pierre Joye <pierre.php_at_gmail.com>
Date: Tue, 21 Dec 2010 17:35:20 +0100

hi,

On Tue, Dec 21, 2010 at 4:21 PM, Yang Tse <yangsita_at_gmail.com> wrote:

>> However I would have appreciated that you noticed me about these
>> changes before so I don't waste my time by working on the patch I sent
>> earlier.
>
> Read points 2.8 and 3.4.4 of http://curl.haxx.se/dev/contribute.html
> and re-read my specific request for separate patches earlier in this
> thread.

Thanks for the link to the contribution howto. I knew I had to learn
that (read: not). The matter here is the amount of work and time it
requires to do it. Doing one step at a time for many of the changes is
simply a waste of time (double work, pointless set of patches being
totally rewamped by the next one, etc.).

It is also not like libcurl and curl are big projects, if we agree on
the changes, I could be done very shortly.

>> Especially as it does one of the changes I proposed while
>> still missing other and still having duplicated configurations or
>> defines.
>
> Your second patch, besides other things, specifically changed the way
> libcurl has been named, when built with msvc, since ages.

The default remains the same. If there are places where the names are
changed by default, then please let me know and I'll fix them.

> Given that it would be impossible to reach consensus on how libcurl
> library should be named when built with msvc, what I committed keeps
> 'traditional' naming convention while allowing easy overriding without
> need to further modify msvc makefiles.

The current makefiles are really bad (no offense meant to the original
authors). The endless set of CFG options and related data makes it
hard to use and to maintain. The use of the dependencies sources
instead of the pre built development libraries do not help either.

> In any case, I confirm you here that other changes will follow soonish
> into the repo. It is up to you If you wish to keep updated your
> patches or repos in sync with ours for each commit, or if you prefer
> to sync once this is stable again.

What kind of changes? Mind to enlighten me so I know what I can or
can't do, to avoid double work, conflicts, etc.?

> Hopefully, If we don't piss off each other, we'll get fine work done.
> So let's keep this as technical as possible.

I do. But I do not consider what's just happened as the correct way to
deal with contributions.

> BTW, top-posting on this list is frowned.
> http://curl.haxx.se/mail/etiquette.html

I did not top post, thanks again for the reference.

Cheers,

-- 
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-12-21