On Thu, 4 Mar 2010, Ben Greear wrote:

> The attached patch fixes two problems:

Hello! I have a question on this piece:

> code = tftp_perform(conn, done);

+ /* If we returned an error, just use that...otherwise, look at internal
codes. */
+ if (code == CURLE_OK) {
+ /* If we have encountered an internal tftp error, translate it. */
+ code = tftp_translate_code(state->error);
+ }

The comment says "If we returned an error", but it then checks if the variable
'code' is OK (which isn't an error). I'd like to see the comment clarified or
the code adjusted!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html