On 03/20/2010 03:45 PM, Daniel Stenberg wrote:
> On Thu, 4 Mar 2010, Ben Greear wrote:
>
>> The attached patch fixes two problems:
>
> Hello! I have a question on this piece:
>
>> code = tftp_perform(conn, done);
>
> + /* If we returned an error, just use that...otherwise, look at
> internal codes. */
> + if (code == CURLE_OK) {
> + /* If we have encountered an internal tftp error, translate it. */
> + code = tftp_translate_code(state->error);
> + }
>
> The comment says "If we returned an error", but it then checks if the
> variable 'code' is OK (which isn't an error). I'd like to see the
> comment clarified or the code adjusted!

If tftp_perform returned an error..use that for return code, but if it was OK, then see if
tftp_translate_code(...) had an error. Basically, both have to be OK to
return OK.

That make sense?

Thanks,
Ben

>
>

-- 
Ben Greear <greearb_at_candelatech.com>
Candela Technologies Inc  http://www.candelatech.com
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html