cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH] FTP PRET support for drftpd servers

From: Daniel Stenberg <>
Date: Sun, 27 Dec 2009 21:42:17 +0100 (CET)

On Sun, 27 Dec 2009, Ingmar Runge wrote:

> here's a patch against today's libcurl snapshot that adds support for the
> proprietary PRET command used by "drftpd" and other servers. ("Docs":
> The patch is not particularly well-tested, but listing and downloads
> definitely worked in my tests. A unit test would be a good idea, too.
> Awaiting your comments. ;-)

Thanks a lot for your efforts to improve libcurl!

First, I think the PRET command is an ugly hack. But I'm also aware it has
been around for ages and it apparently hasn't died off alone so I assume that
is because some people actually use and like this concept and hence there is a
reason to consider PRET support for libcurl.

Other than so, I can't think of a lot more to say than the two issues you said

1 - it doesn't use the source indent rules of the rest of the code and

2 - it would be really useful to get a few test cases for PRET since this is
     a rather rarely used feature and thus it will easily break without getting
     noticed (until after too long that is)

Oh, I can in fact think of two more ones:

3 - I figure it would be useful to add a switch to the curl tool to allow it
     to use this feature (not really libcurl-related but still...)

4 - documentation. I'd like to get the new feature and error code documented
     properly so that users can figure out how to use them!

List admin:
Received on 2009-12-27