cURL / Mailing Lists / curl-library / Single Mail

curl-library

[PATCH] Memory leak in zlib error handling code in content_encoding.c

From: Andre Guibert de Bruet <andy_at_siliconlandmark.com>
Date: Fri, 13 Feb 2009 22:35:03 -0500

Hi,

I found a 64KB (DSIZ) memory leak in lib/content_encoding.c in the
zlib error handling code. I have attached a patch that addresses the
issue. Could it be committed upon review?

Another item of interest: In the inflateInit2(z, -MAX_WBITS) != Z_OK
case, the failure mode is to call process_zlib_error(conn, z) instead
of the exit_zlib(z, &k->zlib_init, process_zlib_error(conn, z)) that
is performed in the other failure modes in the same function. Is there
a technical reason for this that I am not picking up on?

Cheers,
Andy

/* Andre Guibert de Bruet * 436f 6465 2070 6f65 742e 2042 6974 206a */
/* Managing Partner * 6f63 6b65 792e 2053 7973 4164 6d69 6e2e */
/* GSM: +1 734 846 8758 * 2055 4e49 5820 736c 6575 7468 2e00 0000 */
/* WWW: siliconlandmark.com * C/C++, Java, Perl, PHP, SQL, XHTML, XML */

Received on 2009-02-14