Re: [PATCH] Memory leak in zlib error handling code in content_encoding.c
Date: Sat, 14 Feb 2009 10:07:31 +0100 (CET)
On Fri, 13 Feb 2009, Andre Guibert de Bruet wrote:
> I found a 64KB (DSIZ) memory leak in lib/content_encoding.c in the zlib
> error handling code. I have attached a patch that addresses the issue. Could
> it be committed upon review?
It looks fine. I've committed it now,
> Another item of interest: In the inflateInit2(z, -MAX_WBITS) != Z_OK case,
> the failure mode is to call process_zlib_error(conn, z) instead of the
> exit_zlib(z, &k->zlib_init, process_zlib_error(conn, z)) that is performed
> in the other failure modes in the same function. Is there a technical reason
> for this that I am not picking up on?
I must agree with you that it looks like an oversight there. But doesn't this
also result in a memory leak when inflateEnd() is never called?
-- / daniel.haxx.seReceived on 2009-02-14