curl-library
Re: Patch: partial fix for bug #948950
Date: Mon, 22 Nov 2004 23:28:36 +0100 (CET)
On Mon, 22 Nov 2004, David Phillips wrote:
> I think I fixed test 518. It now skips opening extra file descriptors if it
> can't set RLIMIT_NOFILE high enough. I am assuming that libcurl won't need
> more than 16 file descriptors (including 0-2).
Nice! libcurl will use less handles than so, but it doesn't matter.
> I don't see a way for a test to skip itself or print a warning.
I made it get skipped on systems without getrlimit() by extending both the
configure script and the test suite perl script so that only systems with a
getrlimit() function will run test case 518.
> Also, I think that <errorcode> in the data file should be 0, not 2. I am
> guessing that it was set to 2 since the test was failing so often.
Right. I set it to 2 as otherwise the test failed all the time on my box. It
is now back to assuming success.
Thanks!
-- Daniel Stenberg -- http://curl.haxx.se -- http://daniel.haxx.se Dedicated custom curl help for hire: http://haxx.se/curl.htmlReceived on 2004-11-22