> I just committed it to CVS. Please try it out and verify that I
> didn't break anything.

Great! It works just fine.
In Curl_debug() it is better to use:
    switch(type) {
    case CURLINFO_HEADER_IN:
      snprintf(buffer, sizeof(buffer), "[Reply from %s]", host);
      break;
    case CURLINFO_HEADER_OUT:
      snprintf(buffer, sizeof(buffer), "[Send to %s]", host);
      break;
    default: /* actually not in use */
      snprintf(buffer, sizeof(buffer), "[Chunk to/from %s]", host);
      break;
    }

Instead of just:
snprintf(buffer, sizeof(buffer), "[Chunk to/from %s]", host);

The output will be more readable:
* [Reply from hpd301]< 227 Entering Passive Mode (199,221,37,88,212,19)
* [Send to sne465]> PORT 199,221,37,88,212,19
* [Reply from sne465]< 200 PORT command successful.
* [Send to sne465]> RETR /tmp/curlSourceTest.dat
* [Reply from sne465]< 150 Binary data connection for
/tmp/curlSourceTest.dat (199.221.37.88,54291) (9590 bytes).
* [Send to hpd301]> STOR /tmp/curlTargetTest.dat
* [Reply from hpd301]< 150 Opening BINARY mode data connection for
/tmp/curlTargetTest.dat.
* [Reply from hpd301]< 226 Transfer complete.
* [Reply from sne465]< 226 Binary Transfer complete.

Compared with:
* [Chunk to/from hpd301]< 227 Entering Passive Mode
(199,221,37,88,208,211)
* [Chunk to/from sne465]> PORT 199,221,37,88,208,211
* [Chunk to/from sne465]< 200 PORT command successful.
* [Chunk to/from sne465]> RETR /tmp/curlSourceTest.dat
* [Chunk to/from sne465]< 150 Binary data connection for
/tmp/curlSourceTest.dat (199.221.37.88,53459) (9590 bytes).
* [Chunk to/from hpd301]> STOR /tmp/curlTargetTest.dat
* [Chunk to/from hpd301]< 150 Opening BINARY mode data connection for
/tmp/curlTargetTest.dat.
* [Chunk to/from hpd301]< 226 Transfer complete.
* [Chunk to/from sne465]< 226 Binary Transfer complete.

> We really should improve the FTP test server to support 3rd
> party support so that we can add a bunch of test cases for this.

I thought you are using standard FTP server of UNIX/NT vendors.

Another issue: do you know that there is a problem when using
"configure" with "--disable-http" option.

/opt/SUNWspro/bin/cc -g -g -o .libs/curl main.o hugehelp.o urlglob.o
writeout.o writeenv.o getpass.o homedir.o strtoofft.o timeval.o
../lib/.libs/libcurl.so -ldl -lsocket -lnsl -lz
-R/curl-7.12.1-20040606/installation/lib

ild: (undefined symbol) Curl_http_auth_act -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) Curl_http_input_auth -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) Curl_cookie_cleanup -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) Curl_cookie_init -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) Curl_ConnectHTTPProxyTunnel -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) Curl_http_should_fail -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) Curl_digest_cleanup -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) Curl_httpchunk_init -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) Curl_cookie_add -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) Curl_compareheader -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) Curl_httpchunk_read -- referenced in
../lib/.libs/libcurl.so
ild: (undefined symbol) curl_formadd -- referenced in the text segment
of main.o
ild: (undefined symbol) curl_formfree -- referenced in the text segment
of main.o
*** Error code 5
make: Fatal error: Command failed for target `curl'

The information contained in this message is proprietary of Amdocs,
protected from disclosure, and may be privileged.
The information is intended to be conveyed only to the designated recipient(s)
of the message. If the reader of this message is not the intended recipient,
you are hereby notified that any dissemination, use, distribution or copying of
this communication is strictly prohibited and may be unlawful.
If you have received this communication in error, please notify us immediately
by replying to the message and deleting it from your computer.
Thank you.
Received on 2004-06-06