curl-library
Re: CII Best practices
Date: Sun, 17 Jun 2018 16:24:53 +0200
I've used git notes to add meta data to a commit eg. 'reviewed by',
'sob', etc .... maybe a (slightly) more workable approach (instead of
muddying up commit message) is to add SOB as a git note ... unsure if
that fits in with original spirit of CII ... anyhow the current CII
level curl is at is impressive (and instructive) ... many thanks, Jim
On 17 June 2018 at 14:26, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Fri, 15 Jun 2018, Sean MacLennan wrote:
>
>>> - This seems to basically require Signed-off-by: in every commit
>
>
>> I'm not sure this would be much of a hassle. Yes, at first you are going
>> to have to send a lot of "great patch, please add a SOB line", but I think
>> developers are getting used to these.
>
>
> Yeah, I too think we could learn to use them. The question is rather if we
> think they actually add value to the project.
>
> I'm curious if there's actually anyone who did any deeper legal checks of
> wether that line actually makes any difference in jurisdictions compared to
> merely having that "sign-off" implied by the fact that you send the patch to
> us.
>
> I mean, people just add that line automatically anyway. How does that make
> any difference if someone comes after us years later claiming that a commit
> should wrongfully merged into the project?
>
>
> --
>
> / daniel.haxx.se
>
> -------------------------------------------------------------------
> Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
> Etiquette: https://curl.haxx.se/mail/etiquette.html
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
Received on 2018-06-17