cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: sftp download error in 7.49.1

From: Dan Donahue <ddonahue_at_parallelwireless.com>
Date: Tue, 26 Jul 2016 16:17:07 +0000

On Sat, 2016-07-23 at 03:10 -0400, Ray Satiro wrote:
> Yes, we are referring to a git bisect of the curl repository https://
> github.com/curl/curl.git

Thank you for the clarification and detailed instructions. I took the
original request to do a bisect in the general sense (hadn't heard of
git bisect).

I performed the bisect and here is the offending commit that causes
performance issue and eventual dowload timeout:
# curl -V
790d6de485154440d4f8822a54641ee00a0d09f3 is the first bad commit
commit 790d6de485154440d4f8822a54641ee00a0d09f3
Author: Daniel Stenberg <daniel_at_haxx.se>
Date:   Sun Sep 27 20:48:35 2015 +0200

    readwrite_data: set a max number of loops

    ... as otherwise a really fast pipe can "lock" one transfer for
some
    protocols, like with HTTP/2.

:040000 040000 be90c05ef52f4836905b3d25a7a22f0f2a690ef0
8829a22fc115f125e3d9d0282b85da987518d80a M  lib

Offending version:
curl 7.45.0-DEV (powerpc-pw_uniran-linux-gnuspe) libcurl/7.45.0-DEV
zlib/1.2.7 libssh2/1.4.3
Protocols: dict file ftp gopher http imap pop3 rtsp scp sftp smtp
telnet tftp 
Features: Largefile libz UnixSockets 

I've also attached the bisect log in case you're interested.

-------------------------------------------------------------------
List admin: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html

Received on 2016-07-26