cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [Patch] <lwip/opt.h> guard name

From: Gisle Vanem <gvanem_at_yahoo.no>
Date: Mon, 7 Dec 2015 21:08:57 +0100

Ray Satiro wrote:

> I did have a reject in socket.c with this second patch

Which socket.c? I'm not sure what reject this is.

On the same issue; more warnings crept up using GCC 5.1 (TDM-MinGW)
while building with '-DUSE_LWIPSOCK':

In file included from curl_config.h:6:0,
                 from curl_setup.h:41,
                 from amigaos.c:23:
config-win32.h:630:5: warning: "HAVE_WINSOCK2_H" is not defined [-Wundef]
 #if HAVE_WINSOCK2_H && defined(_WIN32_WINNT) && (_WIN32_WINNT >= 0x0600)
     ^

I think it's more correct to say:

--- a/config-win32.h 2015-10-12 18:29:24
+++ b/config-win32.h 2015-12-07 15:46:38
@@ -627,7 +627,7 @@
 /* Define if struct sockaddr_in6 has the sin6_scope_id member. */
 #define HAVE_SOCKADDR_IN6_SIN6_SCOPE_ID 1

-#if HAVE_WINSOCK2_H && defined(_WIN32_WINNT) && (_WIN32_WINNT >= 0x0600)
+#if defined(HAVE_WINSOCK2_H) && defined(_WIN32_WINNT) && (_WIN32_WINNT >= 0x0600)
 #define HAVE_STRUCT_POLLFD 1
 #endif

---
I see nowhere where 'HAVE_WINSOCK2_H' is defined with a value != 1.
What do you think?
-- 
--gv
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2015-12-07