cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Removing the TODO comments

From: Dan Fandrich <dan_at_coneharvesters.com>
Date: Tue, 24 Nov 2015 22:13:43 +0100

On Tue, Nov 24, 2015 at 09:36:37AM +0100, Daniel Stenberg wrote:
> On Fri, 20 Nov 2015, Dan Fandrich wrote:
> >Commit 64e959ff removed most of the TODO comments in the code because "They
> >tend to never get updated anyway so they're frequently inaccurate and we never
> >go back to revisit them anyway." I disagree with this removal.
>
> Okay, I hear you. I got annoyed by some that clearly were inaccurate/old and
> then it struck me that these comments tend to get added to the code and then
> never get updated. I probably overreacted when I removed all of them like
> that. Thanks for speaking up.
>
> I'll revert that patch now and I'll instead address the particular ones I
> think are the most wrong to start with. In the long run I think we're better
> off adding issues to the TODO and KNOWN_BUGS documents so that they're
> easier to find.

I agree that some of them are wish list items that could easily be tracked
separately, but I'm glad to see the rest have made it back in!

>>> Dan
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-11-24