Ray Satiro via curl-library wrote:
> On 10/7/2015 9:10 AM, Daniel Stenberg wrote:
>> On Wed, 7 Oct 2015, Rich Gray wrote:
>>
>>> For what it's worth, CURLINFO_TLS_SSL_PTR seems more meaningful to me
>>> than CURLINFO_TLS_SESSION_V2. For maximum clarity, maybe
>>> CURLINFO_TLS_CTX_PTR could be added as an alias for CURLINFO_TLS_SESSION
>>> and the later "depreciated".
>>
>> I'm with Rich here.
>>
>> We need to consider the long term and "v2" will not age well so ten years
>> down the line this will leave people wondering about the v1. I prefer a
>> clear name that can stand on its own, which makes CURLINFO_TLS_SSL_PTR
>> better in my eyes.
>>
>
> Reviewing this thread we seem to be about evenly split here.
> CURLINFO_TLS_SESSION_V2 I prefer because it's basically the same as
> CURLINFO_TLS_SESSION but with the fix for OpenSSL. CURLINFO_TLS_SSL_PTR also
> has the fix but is less appealing to me because it only returns the pointer
> and not a CURLSSLBACKEND define indicating the SSL backend. We could take
> the CURLINFO_TLS_SESSION_V2 and rename it CURLINFO_TLS_SSL_PTR and do some
> minor doc work, but then it's not directly returning an SSL pointer.

FYI, I have no experience with the TLS components of libcurl. I was just
commenting that _V2 left me cold. Perhaps there is yet a more descriptive
name than CURLINFO_TLS_SSL_PTR. CURLINFO_TLS_OBJECT?? I don't know. Or
use _V2 or CURLINFO_TLS_SESSIONX or something. I defer to those who
actually know about this stuff - what it means and what makes sense.

Cheers!
Rich
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-10-30