cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] nss: implement public key pinning for NSS backend

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Wed, 22 Apr 2015 13:45:36 +0200

On Thursday 02 April 2015 17:42:35 Kamil Dudka wrote:
> On Wednesday 01 April 2015 12:01:24 moparisthebest wrote:
> > On 03/25/2015 09:13 AM, Kamil Dudka wrote:
> > > As the feature window is already closed, I am sending this just to
> > > get some feedback on the patch, will merge it after the release
> > > eventually.
> >
> > I can't comment on the NSS specific code, but it looks complete
> > otherwise as to updating all the docs, runtests.pl, and calling the
> > shared Curl_pin_peer_pubkey() function correctly. If it passes all 4
> > pinning tests (der pass/fail, pem pass/fail) with NSS it should be
> > good to go!
> >
> > Great to see the number of supported backends growing!
>
> Thanks for the review! I will push this as soon as the release is out.

Pushed as b47c17d6:

https://github.com/bagder/curl/commit/b47c17d6

> Kamil
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-04-22