cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH] nss: implement public key pinning for NSS backend

From: Kamil Dudka <>
Date: Thu, 02 Apr 2015 17:42:35 +0200

On Wednesday 01 April 2015 12:01:24 moparisthebest wrote:
> On 03/25/2015 09:13 AM, Kamil Dudka wrote:
> > As the feature window is already closed, I am sending this just to
> > get some feedback on the patch, will merge it after the release
> > eventually.
> I can't comment on the NSS specific code, but it looks complete
> otherwise as to updating all the docs,, and calling the
> shared Curl_pin_peer_pubkey() function correctly. If it passes all 4
> pinning tests (der pass/fail, pem pass/fail) with NSS it should be
> good to go!
> Great to see the number of supported backends growing!

Thanks for the review! I will push this as soon as the release is out.

List admin:
Received on 2015-04-02