Ok -- If this requires more attn, it may just miss this release; c'est
la vie. I'll review your patch and go from there. The darwinssl may
have been coded blind -- so if it's conditionally compiled, I didn't
manage to run it on my *BSD setup -- but I wanted to get a rough
framework in -- so thanks for the note; I'll review.

-bch

On 3/25/15, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Mon, 9 Mar 2015, bch wrote:
>
>> OpenSSL and DarwinSSL w/ suggestions from Steve re: style.
>>
>> Comments welcome.
>
> Thanks a lot and sorry again for my slowness here. My comments in a somewhat
>
> random order:
>
> 1 - Please run 'make checksrc' and fix all nits before you post a patch.
> There
> were several minor formatting quirks. I fixed them.
>
> 2 - Please add the necessary section to the curl_easy_getinfo.3 man page
>
> 3 - Why make set_ssl_version_long() in openssl.c take a struct connectdata
> *
> parameter? Wouldn't a struct SessionHandle straight away make more
> sense?
>
> 4 - The darwinssl version of set_ssl_version_long() seems to not even
> compile.
> It uses a 'connssl' variable that isn't declared!
>
> Finally, I'm attaching my slightly edited version of your diff as a git
> commit. It'll be convenient if you keep it a commit and you just send a full
>
> new patch (as git format-patch outputs) when you have done your ammends to
> it!
>
> --
>
> / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2015-03-26