cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: about https proxy queston

From: laser peter via curl-library <curl-library_at_cool.haxx.se>
Date: Tue, 10 Feb 2015 03:15:41 +0000 (UTC)

Please review Line 649-->653 in the file attached, thanks.

     On Monday, February 9, 2015 8:45 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:
   

 On Thu, 5 Feb 2015, laser peter via curl-library wrote:

> I mean https proxy there in my env.

Yes, but that is still a HTTP proxy. Without the S! =)

> Could you please review the patch? It verified fixed the issue in my ENV. ++
>  /* Bug fix */++  if (rc == 0) {++    sock[0] = conn->sock[FIRSTSOCKET];++  
>  rc = GETSOCK_WRITESOCK(0);++  }+++   /* when we've sent a CONNECT to a
> proxy, we should rather wait for the+      socket to become readable to be
> able to get the response headers */+   if(conn->tunnel_state[FIRSTSOCKET] ==
> TUNNEL_CONNECT) {

I'd love to!

Can you please send a full patch[*] that isn't HTML or otherwise scrambled
(like perhaps attached) when it reaches the list?

[*] = http://curl.haxx.se/dev/contribute.html#How_To_Make_a_Patch_with_git

-- 
  / daniel.haxx.se
   


-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2015-02-10