cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH 0/2] CMake: Fix order-dependent header and library checks

From: Brad King <>
Date: Tue, 11 Nov 2014 13:19:40 -0500

On 11/11/2014 04:42 AM, Jakub Zakrzewski wrote:
>> Here is a patch series to fix it. See individual commit messages for details. Basically they revert some recent changes and add comments
>> explaning why the original code worked the way it did. Whatever issues caused those changes will need to be resolved in another way.
> Thanks for your input.

Thanks for taking a look. Per Daniel's new review policy:

 cmake reviews needed!

please provide the necessary +1 when ready.

> my motivation was to provide better (cleaner) output from
> CMake tests and shorten check times
> On the side note: I still believe, that it'd be better to
> know the dependencies in advance and use CMake-provided
> features during checks. But it's just me ;)

IIRC the checks were originally written that way many years
ago to duplicate what the non-CMake buildsystem was doing
for its checks at the time. Most of the headers/libs do
not actually have dependencies on all of the preceding ones.
Those without dependencies could be split out and made
independent. Those with dependencies could be spelled out
explicitly in order. That would take some investigation
and a lot of testing though.

For now though, the old logic needs to be restored to fix
the build on OS X and a few other platforms.


List admin:
Received on 2014-11-11