cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH 0/2] CMake: Fix order-dependent header and library checks

From: Jakub Zakrzewski <jzakrzewski_at_e2e.ch>
Date: Tue, 11 Nov 2014 09:42:09 +0000

> Here is a patch series to fix it. See individual commit messages for details. Basically they revert some recent changes and add comments
> explaning why the original code worked the way it did. Whatever issues caused those changes will need to be resolved in another way.

Thanks for your input. When changing this my motivation was to provide better (cleaner) output from CMake tests and shorten check times. As I have only few environments to test it witch, I didn't catch the regresssion. Well, sometimes I have to be reminded not refactor everything I see ;)

On the side note: I still believe, that it'd be better to know the dependencies in advance and use CMake-provided features during checks. But it's just me ;)

--
Gruesse,
Jakub
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2014-11-11