cURL / Mailing Lists / curl-library / Single Mail


RE: [PATCH] smb/cifs

From: Nagel, Bill <>
Date: Tue, 11 Nov 2014 15:45:34 +0000

> However, and this is more for my own curiosity, but I couldn’t find any
> mention of it in the manpages :(

I'm not sure if it in the docs, it just something I've noticed.

> I don't want to sound funny about this, but you might prefer to use these
> types (and if it was my own code outside of this project then I would as well),
> however the majority of curl is C89 compliant and we try to keep it as such. I
> appreciate the typedefs you introduce maintains portability but that’s not
> how we do things around here.

Do you prefer that I rename the types and avoid stdint? Like "smb_u32".

> > I believe a #error in curl_ntlm_core.c will catch this.
> I'm sorry but this code needs to compile when NTLM support is not available
> - there are a lot of platforms out there that we compile for where NTLM may
> not be available because of one of the above scenarios. As such we should
> add the following to smb.[c|h] and such like so that is compiles under such
> circumstances:
> #if !defined(CURL_DISABLE_SMB) && defined(USE_NTLM)

I will go with this, and add SSPI support in a later patch:

#if !defined(CURL_DISABLE_SMB) && defined(USE_NTLM) && !defined(USE_WINDOWS_SSPI)



This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments.

List admin:
Received on 2014-11-11