cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH 1/7] Comment and debug output fixes.

From: Carlo Wood <>
Date: Sun, 9 Nov 2014 19:51:53 +0100

On Sun, 9 Nov 2014 17:46:39 +0000
Steve Holme <> wrote:

> As I'm sure you're aware a size_t is 32-bits on x86 platforms and
> 64-bits on x64, however, a long is always 32-bits on LLP64 platforms
> such as Windows :(
> As such it would be better to use our predefined printf format and
> cast the variable to a curl_off_t (as I don’t believe we have one for
> a size_t).

We don't. And yes.

> Also note that the reason some of the code used "0x%p" is that %p may
> or may not contain the 0x (depending on platform and runtime
> implementation) and the original author of this code was probably
> running curl on a platform that didn't, however, I must admit having
> 0x0xdeaddead does look very odd ;-)

It was like the only occurrence of '0x%p' in the code. The rest
just uses %p. I suppose we agree on it to use just '%p'.

> > I copied the DEBUGF line where removal is printed - which uses also
> > %d for the num_connections. Maybe Daniel can fix this when applying
> > the patch, or do you want me to generate a new diff (which isn't a
> > natural way to use git-- and therefore not very trivial :/).
> Attached updated patch enclosed.

I can't open this anyone in my mailer, so now I can't reply to it
with quotes from the patch :p

Nevertheless, I believe this is OK now.

> You will note from my patch that I tried to put your commit comments
> into our standard format. Could you please use this in future? For
> more info please see:

Can you please tell me what I did wrong? I used gits email function
and it produced the emails as they are. What did you have to change?


I think I followed the instructions from there.

> Additionally, could I also ask that you attach your patches to emails
> as well please? Whilst I appreciate it is easier to have the patch
> contents in an email (and this is how I understand the git email
> functionality works) so folk can review it without leaving the email
> software, it makes reviewing the patch through git and applying it
> much more difficult - certainly for us Windows users anyway (part of
> the problem is the line endings aren't maintained in emails but also
> Outlook / Hotmail likes to reformat some of the email, which is why I
> don't normally go near this type of patch :-/

I was copying what Peter Wu did/does...

Carlo Wood <>
List admin:
Received on 2014-11-09