cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [bagder/curl] b5c496: tests: Don't run HTTP digest tests for SSPI based ...

From: Dan Fandrich <dan_at_coneharvesters.com>
Date: Thu, 6 Nov 2014 22:34:34 +0100

On Thu, Nov 06, 2014 at 09:09:40PM +0000, Steve Holme wrote:
> On Thu, 6 Nov 2014, GitHub wrote:
>
> > Added !SSPI to the features list of the HTTP digest tests, as SSPI
> > based builds now use the Windows SSPI messaging API rather than the
> > internal functions, and we can't control the random numbers that get
> > used as part of the digest.
> >
> > M tests/data/test551
>
> Would one of my Linux peers be so kind to help me out please and update /tests/data/test552 and add !SSPI to the top of the features list - just like I did with test551 and the other 31 tests?

Done.

> For some reason, TortoiseGit / mysysGit on Windows doesn't like diffing the file (sometimes displaying nothing - sometimes characters from the Chinesse character set) and then if I ignore that and commit it display - for the number of lines changed and places the following in the patch file:
>
> tests/data/test552 | Bin 142979 -> 142985 bytes
>
> It doesn't seem to matter whether I add the extra line in my trusty copy of Textpad or use a Hex Editor :(
>
> I've just spent the last hour on this so I think a beer is now in order ;-)

This is what I get, too, and for previous commits as well, likely due to the
NUL characters in the file. Using the diff --text option gives me a nice,
normal diff. I get a file size of 142985, too, so it probably would have worked
just fine had you checked it in yourself!

>>> Dan
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-11-06