On Fri, 3 Oct 2014, Nagel, Bill wrote:

This is a very quick email as I've just got in from work (and it's 22:15 here in the UK as I write this) and I need to eat etc...

Thank you for splitting the patch up.

> > 8) Does smb_data.h need to be separate from smb.h? You'll note that
> > there re private smtp only defines and structures in smtp.h.
>
> I really like to keep these separate. These are protocol specific and don't
> need to be included into urldata.h.

As I mentioned in my last email we already have a fair number of protocols that include private structures, enums and #defines in their respective header files which as you know then get included in urldata.h.

Whilst this isn't great - I'd rather not move away from convention for the sake of one protocol. I'm not suggesting we split up every header file into private (local to the protocol) and non-private (function and structure definitions that other source files within libcurl require) but if we were to do this then, without counting, I'm sure there would quite an increase in header files in libcurl :( I appreciate it's only one protocol, and out of all the protocols it's probably has the largest number of private structures, but it's against the way we currently do things.

> > 9) Additionally, as I mentioned in my previous email:
> >
> > * There is not documentation - are you working on that separately?
>
> Documentation, followed by tests, will be the next set of patches.

Great - we look forward to receiving them.

I'll take a look at the patches in more detail tomorrow as I'm pretty shattered now - and hopefully in the meantime others will take a look too ;-)

I'm also aware that we are approaching feature freeze (Wednesday - if memory serves me correctly) so we may be best to place this in a private branch, work with you to improve the patches (if necessary) over the coming weeks and look to include it in the release after next.
 
Kind Regards

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-10-06