> 8) Does smb_data.h need to be separate from smb.h? You'll note that there
> re private smtp only defines and structures in smtp.h.

I really like to keep these separate. These are protocol specific and don't need to be included into urldata.h.

> 9) Additionally, as I mentioned in my previous email:
>
> * Could you please split the patch up into smaller chunks - this makes
> reviewing the work a lot easier and making sure we push changes
> incrementally that don't necessary effect each other. For example the
> configure.ac modifications could be pushed to make sure we don't break
> existing builds, then the addition of the smb files, updates to version,
> updates to curl command line tool, etc... rather than one great big change
> that then breaks things.
> * There is not documentation - are you working on that separately?

Documentation, followed by tests, will be the next set of patches.

-Bill

________________________________

This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-10-06