cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Compile with latest nghttp2

From: Tatsuhiro Tsujikawa <tatsuhiro.t_at_gmail.com>
Date: Wed, 27 Aug 2014 01:08:40 +0900

On Tue, Aug 26, 2014 at 10:44 PM, Tatsuhiro Tsujikawa <tatsuhiro.t_at_gmail.com
> wrote:

>
>
>
> On Tue, Aug 26, 2014 at 9:47 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:
>
>> On Tue, 26 Aug 2014, Tatsuhiro Tsujikawa wrote:
>>
>> The attached patch fixes build error with latest nghttp2.
>>>
>>
>> Lovely, what do you think about also bumping the detection of nghttp2 in
>> curl's configure like this, to make it only detect nghttp2 with this newer
>> API?
>>
>>
> Yeah, ​
> I
> ​ totally agree with you. Should I include this change to the patch?
>
>
​Right, I take my liberty to go forward, here is the ​patch including
configure.ac change.

Best regards,
Tatsuhiro Tsujikawa

> Best regards,
> Tatsuhiro Tsujikawa​
>
>
>> diff --git a/configure.ac b/configure.ac
>> index 3c70540..d51c7e5 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -2758,11 +2758,11 @@ if test X"$want_h2" != Xno; then
>>
>> LDFLAGS="$LDFLAGS $LD_H2"
>> CPPFLAGS="$CPPFLAGS $CPP_H2"
>> LIBS="$LIB_H2 $LIBS"
>>
>> - AC_CHECK_LIB(nghttp2, nghttp2_session_client_new,
>> + AC_CHECK_LIB(nghttp2, nghttp2_session_callbacks_set_send_callback,
>> [
>> AC_CHECK_HEADERS(nghttp2/nghttp2.h,
>> curl_h2_msg="enabled (nghttp2)"
>> NGHTTP2_ENABLED=1
>> AC_DEFINE(USE_NGHTTP2, 1, [if nghttp2 is in use])
>>
>>
>> --
>>
>> / daniel.haxx.se
>> -------------------------------------------------------------------
>> List admin: http://cool.haxx.se/list/listinfo/curl-library
>> Etiquette: http://curl.haxx.se/mail/etiquette.html
>
>
>

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2014-08-26